Introduce ELF loader with networking support #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `elfloader-net/` directory (with networking support) - `Config.uk`: ELF Loader configuration - `rootfs/`: setup for building Linux ELFs, with simple C HTTP server - `Makefile`: for building the ELF Loader - `Makefile.uk`: empty placeholder file required by build system - `fc.x86_64.json`: Firecracker configuration - `README.md`: instructions Signed-off-by: Razvan Deaconescu <[email protected]>
StefanJum
suggested changes
Oct 18, 2024
There was a problem hiding this comment.
I get a lot of build errors related to lwip, see the comments.
Also, is there a reason why we have two separate elfloader application, one with and one without networking? Why would we not just use the one with networking enabled?
I think having 2 instances of the same app might get hard to maintain over time, but if there is a good reason for it then it's ok.
| ```console | ||
| test -d ../repos/unikraft || git clone https://github.com/unikraft/unikraft ../repos/unikraft | ||
| test -d ../repos/libs/libelf || git clone https://github.com/unikraft/lib-libelf ../repos/libs/libelf | ||
| test -d "../repos/libs/lwip" || git clone https://github.com/unikraft/lib-lwip ../repos/libs/lwip |
There was a problem hiding this comment.
Suggested change
| test -d "../repos/libs/lwip" || git clone https://github.com/unikraft/lib-lwip ../repos/libs/lwip | |
| test -d "../repos/libs/lwip" || git clone https://github.com/unikraft/lib-lwip ../repos/libs/lwip | |
| test -d "../repos/apps/elfloader" || git clone https://github.com/unikraft/lib-lwip ../repos/apps/elfloader |
There was a problem hiding this comment.
I suppose we should also clone the elfloader app right?
| CONFIG_LIBDEVFS_AUTOMOUNT=y | ||
| CONFIG_LIBLWIP=y | ||
| CONFIG_LIBUKNETDEV_EINFO_LIBPARAM=y' | ||
| UK_DEFCONFIG=/tmp/defconfig make defconfig |
There was a problem hiding this comment.
I get a lot of warnings when doing the defconfig
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:20:warning: choice value used outside its choice group
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:25:warning: choice value used outside its choice group
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:37:warning: choice value used outside its choice group
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:112:warning: choice value used outside its choice group
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:119:warning: choice value used outside its choice group
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:135:warning: choice value used outside its choice group
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:137:warning: choice value used outside its choice group
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:139:warning: choice value used outside its choice group
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:141:warning: choice value used outside its choice group
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:143:warning: choice value used outside its choice group
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:145:warning: choice value used outside its choice group
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:147:warning: choice value used outside its choice group
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:168:warning: choice value used outside its choice group
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:173:warning: choice value used outside its choice group
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:12:warning: choice default symbol 'LWIP_UNIKRAFT21X' is not contained in the choice
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:109:warning: choice default symbol 'LWIP_THREADS' is not contained in the choice
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:133:warning: choice default symbol 'LWIP_STACKTHREAD_MBOX_SIZE_256' is not contained in the choice
/projects/unikraft/catalog-core/repos/apps/elfloader/Config.uk:165:warning: choice default symbol 'LWIP_HEAP' is not contained in the choice
and a lot of build errors related to lwip, which should have the same cause i suppose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
elfloader-net/directory (with networking support)Config.uk: ELF Loader configurationrootfs/: setup for building Linux ELFs, with simple C HTTP serverMakefile: for building the ELF LoaderMakefile.uk: empty placeholder file required by build systemfc.x86_64.json: Firecracker configurationREADME.md: instructions