Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22952 Make configure --help show --enable-* / --disable-* consistently #3254

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

roubert
Copy link
Member

@roubert roubert commented Oct 24, 2024

It should print just how to toggle the default. Following this shema, it is not necessary to include default=yes/no in the output.

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22952
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

ALLOW_MANY_COMMITS=true

@roubert roubert marked this pull request as ready for review October 24, 2024 20:03
@roubert roubert requested a review from srl295 October 24, 2024 20:03
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better

@roubert roubert merged commit 23673a1 into unicode-org:main Oct 24, 2024
91 checks passed
@roubert roubert deleted the 22952 branch October 24, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants