Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22765 fix uloc_addLikelySubtags on "und@x=private" #3240

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

FrankYFTang
Copy link
Contributor

Fix Locale addLikelySubtags when input is "und@x=private"
Since the code are shared by matcher and addLikelySubtags the behavior for this special case need to check an additional condition.
For Java, just add the test case.

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22765
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOKTM...

@FrankYFTang FrankYFTang merged commit 1dcb4bc into unicode-org:main Oct 16, 2024
101 checks passed
@FrankYFTang FrankYFTang deleted the ICU-22765-private branch October 16, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants