Skip to content

Commit

Permalink
ICU-22324 Mavenization, publish the root pom to Maven
Browse files Browse the repository at this point in the history
  • Loading branch information
mihnita authored and pedberg-icu committed Sep 29, 2023
1 parent 07137b6 commit 76b9e08
Show file tree
Hide file tree
Showing 20 changed files with 209 additions and 97 deletions.
10 changes: 3 additions & 7 deletions .github/workflows/maven.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
# https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow

env:
SHARED_MVN_ARGS: '--show-version --no-transfer-progress'
SHARED_MVN_ARGS: '--show-version'

permissions:
contents: read
Expand All @@ -34,13 +34,9 @@ jobs:
echo Github Ref ${GITHUB_REF} @ ${GITHUB_SHA};
cd icu4j
mvn deploy ${SHARED_MVN_ARGS} \
-pl main/icu4j \
-pl :icu4j,:utilities-for-cldr,:icu4j-root \
-DaltDeploymentRepository=github::https://maven.pkg.github.com/${GITHUB_REPOSITORY} \
-P with_sources
mvn deploy ${SHARED_MVN_ARGS} \
-pl tools/utilities-for-cldr \
-DaltDeploymentRepository=github::https://maven.pkg.github.com/${GITHUB_REPOSITORY} \
-P cldr_tools,with_sources
-P cldr_utilities,with_sources
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# Note: can use 0.0.0-${GITHUB_SHA} as the version for hash-based.
Expand Down
12 changes: 12 additions & 0 deletions icu4j/demos/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,16 @@
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<!-- We don't want to deploy this to Maven -->
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>

</project>
10 changes: 3 additions & 7 deletions icu4j/main/charset/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,13 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.ibm.icu</groupId>
<artifactId>main</artifactId>
<artifactId>icu4j-root</artifactId>
<version>74.1-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>

<artifactId>icu4j-charset</artifactId>
<description>icu4j-charset is a supplemental library for icu4j, implementing Java Charset SPI.</description>

<properties>
<icu4j.api.doc.root.dir>${project.basedir}/../..</icu4j.api.doc.root.dir>
Expand Down Expand Up @@ -68,12 +70,6 @@
</archive>
</configuration>
</plugin>
<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<configuration>
<skip>false</skip>
</configuration>
</plugin>
</plugins>
</build>

Expand Down
15 changes: 14 additions & 1 deletion icu4j/main/collate/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.ibm.icu</groupId>
<artifactId>main</artifactId>
<artifactId>icu4j-root</artifactId>
<version>74.1-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>

<artifactId>collate</artifactId>
Expand Down Expand Up @@ -66,4 +67,16 @@
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<!-- We don't want to deploy this to Maven -->
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>

</project>
10 changes: 9 additions & 1 deletion icu4j/main/common_tests/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.ibm.icu</groupId>
<artifactId>main</artifactId>
<artifactId>icu4j-root</artifactId>
<version>74.1-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>

<artifactId>common_tests</artifactId>
Expand Down Expand Up @@ -96,6 +97,13 @@
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<!-- We don't want to deploy this to Maven -->
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>

Expand Down
10 changes: 9 additions & 1 deletion icu4j/main/core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.ibm.icu</groupId>
<artifactId>main</artifactId>
<artifactId>icu4j-root</artifactId>
<version>74.1-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>

<artifactId>core</artifactId>
Expand Down Expand Up @@ -60,6 +61,13 @@
</archive>
</configuration>
</plugin>
<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<!-- We don't want to deploy this to Maven -->
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>

Expand Down
15 changes: 14 additions & 1 deletion icu4j/main/currdata/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.ibm.icu</groupId>
<artifactId>main</artifactId>
<artifactId>icu4j-root</artifactId>
<version>74.1-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>

<artifactId>currdata</artifactId>
Expand All @@ -26,4 +27,16 @@
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<!-- We don't want to deploy this to Maven -->
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>

</project>
11 changes: 9 additions & 2 deletions icu4j/main/framework/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.ibm.icu</groupId>
<artifactId>main</artifactId>
<artifactId>icu4j-root</artifactId>
<version>74.1-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>

<artifactId>framework</artifactId>
Expand Down Expand Up @@ -46,8 +47,14 @@
</archive>
</configuration>
</plugin>
<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<!-- We don't want to deploy this to Maven -->
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>


</project>
12 changes: 5 additions & 7 deletions icu4j/main/icu4j/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,14 @@

<parent>
<groupId>com.ibm.icu</groupId>
<artifactId>main</artifactId>
<artifactId>icu4j-root</artifactId>
<version>74.1-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>

<artifactId>icu4j</artifactId>
<description>International Components for Unicode for Java (ICU4J) is a mature, widely used Java library
providing Unicode and Globalization support</description>

<properties>
<icu4j.api.doc.root.dir>${project.basedir}/../..</icu4j.api.doc.root.dir>
Expand Down Expand Up @@ -84,6 +87,7 @@
<createDependencyReducedPom>true</createDependencyReducedPom>
<dependencyReducedPomLocation>${project.build.directory}/dependency-reduced-pom.xml</dependencyReducedPomLocation>
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
<useDependencyReducedPomInJar>true</useDependencyReducedPomInJar>
<transformers>
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
<manifestEntries>
Expand All @@ -110,12 +114,6 @@
</filesets>
</configuration>
</plugin>
<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<configuration>
<skip>false</skip>
</configuration>
</plugin>
</plugins>
</build>

Expand Down
15 changes: 14 additions & 1 deletion icu4j/main/langdata/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.ibm.icu</groupId>
<artifactId>main</artifactId>
<artifactId>icu4j-root</artifactId>
<version>74.1-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>

<artifactId>langdata</artifactId>
Expand All @@ -26,4 +27,16 @@
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<!-- We don't want to deploy this to Maven -->
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>

</project>
11 changes: 3 additions & 8 deletions icu4j/main/localespi/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,13 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.ibm.icu</groupId>
<artifactId>main</artifactId>
<artifactId>icu4j-root</artifactId>
<version>74.1-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>

<artifactId>icu4j-localespi</artifactId>
<description>icu4j-localespi is a supplemental library for icu4j, implementing Java Locale SPI.</description>

<properties>
<proj.displayname>JDK locale service provider</proj.displayname>
Expand Down Expand Up @@ -183,13 +185,6 @@
</configuration>
</plugin>

<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<configuration>
<skip>false</skip>
</configuration>
</plugin>

</plugins>
</build>

Expand Down
43 changes: 0 additions & 43 deletions icu4j/main/pom.xml

This file was deleted.

15 changes: 14 additions & 1 deletion icu4j/main/regiondata/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.ibm.icu</groupId>
<artifactId>main</artifactId>
<artifactId>icu4j-root</artifactId>
<version>74.1-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>

<artifactId>regiondata</artifactId>
Expand All @@ -26,4 +27,16 @@
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<!-- We don't want to deploy this to Maven -->
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>

</project>
15 changes: 14 additions & 1 deletion icu4j/main/translit/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.ibm.icu</groupId>
<artifactId>main</artifactId>
<artifactId>icu4j-root</artifactId>
<version>74.1-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>

<artifactId>translit</artifactId>
Expand Down Expand Up @@ -61,4 +62,16 @@
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<artifactId>maven-deploy-plugin</artifactId>
<!-- We don't want to deploy this to Maven -->
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>

</project>
Loading

0 comments on commit 76b9e08

Please sign in to comment.