ICU-22730 Fix int32_t overflow in Persian calendar

unicode-org · Sep 20, 2024 · 48cc878 · 48cc878
1 parent b3bf9f8
commit 48cc878
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/icu4c/source/i18n/persncal.cpp b/icu4c/source/i18n/persncal.cpp
@@ -217,7 +217,8 @@ int32_t PersianCalendar::handleGetExtendedYear(UErrorCode& status) {
  * method is called.
  */
 void PersianCalendar::handleComputeFields(int32_t julianDay, UErrorCode& status) {
-    int64_t daysSinceEpoch = julianDay - PERSIAN_EPOCH;
+    int64_t daysSinceEpoch = julianDay;
+    daysSinceEpoch -= PERSIAN_EPOCH;
     int64_t year = ClockMath::floorDivideInt64(
         33LL * daysSinceEpoch + 3LL, 12053LL) + 1LL;
     if (year > INT32_MAX || year < INT32_MIN) {