Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ICU-22465 Change .s to .data() for replacing TinyString with CharString.
This was forgotten by ICU-7496 which replaced the local TinyString data type with the shared CharString data type, but as it's in code heavily nested in #ifdef's it hasn't been noticed until now.
- Loading branch information
1fc560c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
2
.TestCharsetEncoderICU
12.3169442159181
ns/iter4.0550608273607915
ns/iter3.04
This comment was automatically generated by workflow using github-action-benchmark.
1fc560c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
2
.TestCharsetEncoderICU
12.25386288949332
ns/iter4.0550608273607915
ns/iter3.02
This comment was automatically generated by workflow using github-action-benchmark.
1fc560c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
2
.TestCharsetEncoderICU
9.861143756524681
ns/iter4.0550608273607915
ns/iter2.43
This comment was automatically generated by workflow using github-action-benchmark.