Skip to content

Commit

Permalink
ICU-22465 Change .s to .data() for replacing TinyString with CharString.
Browse files Browse the repository at this point in the history
This was forgotten by ICU-7496 which replaced the local TinyString data
type with the shared CharString data type, but as it's in code heavily
nested in #ifdef's it hasn't been noticed until now.
  • Loading branch information
roubert committed Aug 21, 2023
1 parent a7a2fdb commit 1fc560c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion icu4c/source/common/udata.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1196,7 +1196,7 @@ doOpenChoice(const char *path, const char *type, const char *name,
*p = U_FILE_SEP_CHAR;
}
#if defined (UDATA_DEBUG)
fprintf(stderr, "Changed path from [%s] to [%s]\n", path, altSepPath.s);
fprintf(stderr, "Changed path from [%s] to [%s]\n", path, altSepPath.data());
#endif
path = altSepPath.data();
}
Expand Down

3 comments on commit 1fc560c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 1fc560c Previous: a7a2fdb Ratio
TestCharsetEncoderICU 12.3169442159181 ns/iter 4.0550608273607915 ns/iter 3.04

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 1fc560c Previous: a7a2fdb Ratio
TestCharsetEncoderICU 12.25386288949332 ns/iter 4.0550608273607915 ns/iter 3.02

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 1fc560c Previous: a7a2fdb Ratio
TestCharsetEncoderICU 9.861143756524681 ns/iter 4.0550608273607915 ns/iter 2.43

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.