[UNDERTOW-2404] Add default sorting by type and name in directory lis… #1660
Conversation
xjusko
force-pushed
the
UNDERTOW-2404
branch
from
d669b70
to
fe9818b
Compare
baranowb
added
enhancement
|
|
||
| int state = 0; | ||
| String parent = getParentPath(path, state); | ||
|
|
||
| SimpleDateFormat format = new SimpleDateFormat("MMM dd, yyyy HH:mm:ss", Locale.US); |
There was a problem hiding this comment.
Why? Its an enhancement, lets improve and ditch imperials( or possibly Locale.getDefault() and make decision based on this info?
| Comparator<Resource> comparator; | ||
| if ("lastModified".equals(sortColumn)) { | ||
| comparator = Comparator.comparing( | ||
| entry -> (entry.getLastModified() == null) ? new Date(0L) : entry.getLastModified() |
There was a problem hiding this comment.
if its somehow possible, maybe just use creation date rather than 1970 ?
There was a problem hiding this comment.
There is no creation date, but I think using a string like Unknown or Not Available. What do you think?
There was a problem hiding this comment.
It makes sense to me. As we sure that it is possible to get a null here? Maybe we even want to have something like: "-"
Such as: last modified: -
xjusko
force-pushed
the
UNDERTOW-2404
branch
from
fe9818b
to
b887985
Compare
| Comparator<Resource> comparator; | ||
| if ("lastModified".equals(sortColumn)) { | ||
| comparator = Comparator.comparing( | ||
| entry -> (entry.getLastModified() == null) ? new Date(0L) : entry.getLastModified() |
There was a problem hiding this comment.
It makes sense to me. As we sure that it is possible to get a null here? Maybe we even want to have something like: "-"
Such as: last modified: -
fl4via
removed
the
waiting peer review
xjusko
force-pushed
the
UNDERTOW-2404
branch
from
b887985
to
eb1c957
Compare
…ting view; enable clickable name and size column headers for custom sorting
xjusko
force-pushed
the
UNDERTOW-2404
branch
from
eb1c957
to
6b4575f
Compare
…ting view; enable clickable name and size column headers for custom sorting
https://issues.redhat.com/browse/UNDERTOW-2404