[UNDERTOW-2431] Bump jboss-parent to 46, checkstyle and slightly upda… #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te src to align with new rules
baranowb
added
enhancement
|
This PR needs rebase so CI can run @baranowb |
|
@baranowb FYI, I'll be looking into what is needed to release the checkstyles project so we can move forward with this PR. |
|
ditto here #1654 I'm marking both as duplicates and linking the PRs so it can be clear that they are alternatives to the same issue |
fl4via
added
duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…te src to align with new rules
Issue: https://issues.redhat.com/browse/UNDERTOW-2431
On hold, this require release of new undertow-checkstyle and decision which approach will be better.
This PR assumes no change in config, hence "MAX" changes are required.
Alternative: #1654