[UNDERTOW-2422] Return the protocol field of the HttpServerExchange into the status line #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ropalka
approved these changes
Aug 6, 2024
ropalka
added
bug fix
|
@ropalka The two test failures on JDK17-core, Mac and Windows, are "Buffer Leaks", which are listed as intermittent in the known test issues ticket. The failure in testRstOnPush in JDK11-ipv6 on ubuntu is, I think, another intermittent. I believe in the prior CI run, this same test failed in a different environment, and succeeded in this run. I believe that this CI run should be treated as having succeeded and that testRstOnPush should be added to the known issues list. |
baranowb
approved these changes
Aug 14, 2024
EarthJeff
force-pushed
the
UNDERTOW-2422
branch
from
6e34590
to
f070969
Compare
|
I have squashed the 4 commits into 1. |
fl4via
requested changes
Aug 22, 2024
| @@ -0,0 +1,141 @@ | |||
| /* | |||
| * JBoss, Home of Professional Open Source. | |||
| throw UndertowMessages.MESSAGES.protocolTooLargeForBuffer(protocolString); | ||
| } | ||
| protocol.appendTo(buffer); | ||
| // append status code, reasopn phrase, and headers |
fl4via
added
waiting PR update
…ine. Add tests for this and the default behavior.
EarthJeff
force-pushed
the
UNDERTOW-2422
branch
from
f070969
to
ced7235
Compare
|
@fl4via I have made the requested changes (and squashed the commit). |
fl4via
approved these changes
Sep 18, 2024
fl4via
added
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/UNDERTOW-2422
Currently, no matter what you set the HttpServerExchange.protocol field to, the value "HTTP/1.1" will always be used. This change will use the value of the protocol field (or "HTTP/1.1" if the field is empty) in the HTTP response's status line.
There is a test included in this PR. It confirms the default behavior and the new behavior.