Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check validation rules for incorrectly added values #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kshychko
Copy link
Contributor

@kshychko kshychko commented Feb 9, 2024

Code List

Recommendation No. 24 Trade and Transport Status Codes

Maintenance Request issue

Ref #14 , #15

Mentions:

@uncefact/vocab-codes-maintainers

@kshychko kshychko requested a review from a team as a code owner February 9, 2024 11:42
Copy link

github-actions bot commented Feb 9, 2024

A new code list value was added, but CI was not set to +:

{"CI":"","Code":"380","Name":"New Code #380","Description":"New code #380 description."}
{"CI":"*","Code":"381","Name":"New Code #381","Description":"New code #381 description."}

Copy link
Contributor Author

@kshychko kshychko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI values as suggested

Comment on lines +347 to +348
,380,New Code #380,New code #380 description.
*,381,New Code #381,New code #381 description.
Copy link
Contributor Author

@kshychko kshychko Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
,380,New Code #380,New code #380 description.
*,381,New Code #381,New code #381 description.
+,380,New Code #380,New code #380 description.
+,381,New Code #381,New code #381 description.

@kshychko kshychko self-assigned this Feb 9, 2024
@kshychko kshychko added MR Maintenance Request Rec-24 Recommendation 24 Code List labels Feb 9, 2024
@kshychko kshychko changed the title test: check validation rules fial for incorrectly added values test: check validation rules for incorrectly added values Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MR Maintenance Request Rec-24 Recommendation 24 Code List
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant