Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ora file decompression fastq pair component #624

Merged
merged 4 commits into from
Nov 2, 2024
Merged

Added ora file decompression fastq pair component #624

merged 4 commits into from
Nov 2, 2024

Conversation

alexiswl
Copy link
Member

TODO

  • Test conversion on newest outputs from the development bssh run
  • Test decompression on a fastq pair from step 1

@alexiswl alexiswl added the feature New feature label Oct 30, 2024
@alexiswl alexiswl self-assigned this Oct 30, 2024
@victorskl victorskl linked an issue Nov 1, 2024 that may be closed by this pull request
Build ora compression service #533
Closed
victorskl
victorskl approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@alexiswl alexiswl force-pushed the feature/add-ora-decompression branch from 674bb1c to deab464 Compare November 1, 2024 07:56
@alexiswl alexiswl force-pushed the feature/add-ora-decompression branch from deab464 to 89b6b41 Compare November 1, 2024 08:01
@alexiswl
Copy link
Member Author

alexiswl commented Nov 2, 2024

Ha! The cdk nag suppressions need to come AFTER the infringing line in the stack. I really didn't think it would matter

@alexiswl alexiswl merged commit 27f5e3b into main Nov 2, 2024
6 checks passed
@alexiswl alexiswl deleted the feature/add-ora-decompression branch November 2, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reisingerf reisingerf reisingerf approved these changes

@victorskl victorskl victorskl approved these changes

Assignees

@alexiswl alexiswl

Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build ora compression service
3 participants
@alexiswl @victorskl @reisingerf