Fix calling getAncestors on empty collection (#20)

* Fix executing getAncestors on empty collection
umbrellio · Mar 16, 2020 · 31b5e0d · 31b5e0d
1 parent c87bae6
commit 31b5e0d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/Helpers/LTreeHelper.php b/src/Helpers/LTreeHelper.php
@@ -93,8 +93,11 @@ public static function pathAsString($path): string
 
     public static function getAncestors(Collection $collection): Collection
     {
+        if ($collection->count() === 0) {
+            return new Collection();
+        }
         $first = $collection->first();
-        $paths = $collection->pluck('path')->map(function ($item) {
+        $paths = $collection->pluck($first->getLtreePathColumn())->map(function ($item) {
             return "'${item}'";
         });
         $paths = $paths->implode(', ');

diff --git a/tests/Functional/LtreeTest.php b/tests/Functional/LtreeTest.php
@@ -137,6 +137,7 @@ public function deleteViaServiceSubtree(): void
     /** @test */
     public function ancestors(): void
     {
+        $this->assertCount(0, LTreeHelper::getAncestors(new CollectionBase()));
         $nodes = $this->createTreeNodes($this->getTreeNodes());
         $this->assertSame(3, $nodes[1]::ancestorsOf($nodes[6])->get()->count());
         $this->assertTrue($nodes[2]->isParentOf(5));