Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content.EditorDirectiveController: added formSubmittedValidationFailed broadcast to prevent fields to stay disabled #17018

Merged

Conversation

Yinzy00
Copy link
Contributor

@Yinzy00 Yinzy00 commented Sep 6, 2024

Content.EditorDirectiveController: added formSubmittedValidationFailed broadcast to prevent fields to stay disabled

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #17019

Version

v13.5.0 RC

Description

#16961 resolved an issue with content saving.

We discovered that when attempting to save and publish with invalid fields, those fields remained disabled. After some investigation, we found that triggering the formSubmittedValidationFailed broadcast resolved the problem.

Steps to reproduce

  1. Add a mandatory text field to a doctype
  2. Add a non mandatory text field to that doctype
  3. Create an instance of that doctype
  4. Save and publish without value
    => After validation text fields (and blocklist, mediapicker, ...) will stay disabled

In collab with @NielsAudoor ;)

…d broadcast to prevent fields to stay disabled
Copy link

github-actions bot commented Sep 6, 2024

Hi there @Yinzy00, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@georgebid
Copy link
Contributor

Hey @Yinzy00 thank you for your PR! Someone on the Core Collaborators team will review this soon 😄

Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch. I have tested and it works!

@nielslyngsoe nielslyngsoe merged commit 5fe18bb into umbraco:v13/dev Sep 9, 2024
15 of 16 checks passed
madsoulswe pushed a commit to madsoulswe/Umbraco-CMS that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants