Don't export MD5 byteReverse symbol on big-endian #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise this fails the test which checks that all exported symbols begin with kvz_ prefix.
Jovasa
added
safe to test
|
Thanks, I don't have a big big-endian system to check this but seems good to me. |
FYI, I have used https://github.com/marketplace/actions/run-on-architecture to cover big-endian (and 32-bit) on GH CI for other projects before. It doesn't always work but it's still been useful before. Would a PR to add it to this project's CI be helpful? |
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Dec 19, 2023
Trivial fix and only affects BE so no revbump. See: ultravideo/kvazaar#377 Bug: https://bugs.gentoo.org/902217 Signed-off-by: Matoro Mahri <[email protected]>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Dec 19, 2023
Trivial fix and only affects BE so no revbump. See: ultravideo/kvazaar#377 Bug: https://bugs.gentoo.org/902217 Signed-off-by: Matoro Mahri <[email protected]> Closes: #34364 Signed-off-by: Sam James <[email protected]>
flint2
pushed a commit
to flint2/gentoo
that referenced
this pull request
Dec 19, 2023
Trivial fix and only affects BE so no revbump. See: ultravideo/kvazaar#377 Bug: https://bugs.gentoo.org/902217 Signed-off-by: Matoro Mahri <[email protected]> Closes: gentoo#34364 Signed-off-by: Sam James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise this fails the test which checks that all exported symbols begin with kvz_ prefix.