Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove some Utils modules #65

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Conversation

anmonteiro
Copy link
Collaborator

  • JOSE supports OCaml 4.08+
  • These functions are all available in 4.08

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #65 (7afcb46) into master (226d4c9) will increase coverage by 0.61%.
Report is 1 commits behind head on master.
The diff coverage is 86.60%.

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   74.65%   75.26%   +0.61%     
==========================================
  Files           8        8              
  Lines         935      926       -9     
==========================================
- Hits          698      697       -1     
+ Misses        237      229       -8     
Files Changed Coverage Δ
jose/Jwt.ml 79.41% <80.00%> (ø)
jose/Jwe.ml 84.12% <84.14%> (+1.22%) ⬆️
jose/Jwk.ml 66.46% <84.61%> (-0.14%) ⬇️
jose/Jws.ml 83.89% <92.59%> (-0.68%) ⬇️
jose/Header.ml 92.15% <100.00%> (ø)
jose/Jwks.ml 90.00% <100.00%> (ø)
jose/Utils.ml 89.65% <100.00%> (+17.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ulrikstrid
Copy link
Owner

I will review this a bit later today

jose/Utils.ml Outdated Show resolved Hide resolved
@anmonteiro
Copy link
Collaborator Author

addressed review

@ulrikstrid ulrikstrid merged commit 9450322 into master Sep 20, 2023
7 of 9 checks passed
@ulrikstrid ulrikstrid deleted the anmonteiro/rm-code branch September 20, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants