Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HR4 and SFS baseline update: Improve convection/radiation interaction in the GFS physics suite #2340

Merged
merged 24 commits into from
Jul 20, 2024

Conversation

lisa-bengtsson
Copy link
Contributor

@lisa-bengtsson lisa-bengtsson commented Jun 25, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

The GFS physics suite at 100km yields too large cloud cover and optical depth, causing too much cloud shielding and a drift in Sea Surface Temperatures, SST for seasonal prediction. This is an issue for the Seasonal Forecast System baseline. The issue was identified to be related to too much convective cloud condensate passed in from the cumulus convection scheme.

A scale adaptive solution is proposed and tested for SFS and GFS resolutions, outputting updraft values of in-cloud condensate. We propose to add this change to SFS baselines as well as the HR4 prototype of the GFS. In testing we also tune the minimum background diffusivity in the inversion layer near the PBL top (xkinv1) from xkinv1=0.4 to xkinv1=0.15 in order to not reduce convective clouds too much in marine stratocumulus.

Commit Message:


  * FV3 - update pointer to ccpp-physics
    * ccpp-physics - update convection and PBL schemes to improve cloud/convection interaction
   

Priority:

  • High: Time-sensitive project (HR4 of GFS and SFS baselines)

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@grantfirl
Copy link
Collaborator

@lisa-bengtsson It looks like there was a merge issue with the test_changes.list and the Hera log. I'm seeing that those files need to be merged manually (contains "<<<HEAD" etc.). Could you check this?

@jkbk2004
Copy link
Collaborator

@lisa-bengtsson can you sync up branch? I like to test on my side as well.

@lisa-bengtsson
Copy link
Contributor Author

@lisa-bengtsson can you sync up branch? I like to test on my side as well.

I just synced up the branch, after addressing the issue causing seg fault. Could you kindly test on your end? I will restart the full RT suite now.

@FernandoAndrade-NOAA FernandoAndrade-NOAA added Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's. labels Jul 18, 2024
@zach1221
Copy link
Collaborator

@lisa-bengtsson could you add user epic-cicd-jenkins as a collaborator to this PR's branch? It's just to enable the pipeline to post logs.

@lisa-bengtsson
Copy link
Contributor Author

@lisa-bengtsson could you add user epic-cicd-jenkins as a collaborator to this PR's branch? It's just to enable the pipeline to post logs.

Sure, how do I do that?

@jkbk2004
Copy link
Collaborator

@lisa-bengtsson could you add user epic-cicd-jenkins as a collaborator to this PR's branch? It's just to enable the pipeline to post logs.

Sure, how do I do that?

@lisa-bengtsson You can add the user epic-cicd-jenkins in your repo: settings/access/Collaborators-and-Teams

@zach1221 zach1221 added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. and removed Waiting for Reviews The PR is waiting for reviews from associated component PR's. labels Jul 18, 2024
@lisa-bengtsson
Copy link
Contributor Author

@lisa-bengtsson could you add user epic-cicd-jenkins as a collaborator to this PR's branch? It's just to enable the pipeline to post logs.

Sure, how do I do that?

@lisa-bengtsson You can add the user epic-cicd-jenkins in your repo: settings/access/Collaborators-and-Teams

Ok, I added epic-cicd-jenkins from my fork, hopefully that works?

@zach1221 zach1221 added jenkins-ort run ORT testing and removed jenkins-ort run ORT testing labels Jul 18, 2024
@FernandoAndrade-NOAA
Copy link
Collaborator

Hera baseline creation timed out for cpld_control_nowave_noaero_p8 gnu, rerunning. The rest of the tests seem to be fine. @BrianCurtis-NOAA FYI we are starting testing for this PR.

@zach1221
Copy link
Collaborator

Ok I think we're ready to begin merge process.

@grantfirl
Copy link
Collaborator

@zach1221 ufs-community/ccpp-physics#216 is merged and NOAA-EMC/fv3atm#851 is updated and ready for merge.

@zach1221
Copy link
Collaborator

@lisa-bengtsson FV3atm PR-815 is merged. Please update hash and revert .gitmodule url.
Hash: NOAA-EMC/fv3atm@2527c11

@jkbk2004 jkbk2004 merged commit c127601 into ufs-community:develop Jul 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants