Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitmodules and submodule pointer for fv3atm for code review and testing #2123

Closed

Conversation

tanyasmirnova
Copy link
Contributor

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full RT suite (compared to current baselines) on either Hera/Derecho/Hercules AND have committed the log to my PR branch.
  • Add list of all failed regression tests in "Regression Tests" section.

PR Information

Description

The output of surface runoff is changed from instantaneous to accumulated surface runoff in the RUC LSM driver.

Commit Message

Priority

  • Critical Bugfix (This PR contains a critical bug fix and should be prioritized.)
  • High (This PR contains a feature or fix needed for a time-sensitive project (eg, retrospectives, implementations))
  • Normal

Blocking Dependencies

Git Issues Fixed By This PR

ufs-community/ccpp-physics#164

Changes

One-line change in the RUC LSM driver: lsm_ruc.F90

Subcomponent (with links)

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
FAILED REGRESSION TESTS

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@grantfirl
Copy link
Collaborator

@tanyasmirnova Has this gone through RTs? Do you need us to help?

@tanyasmirnova
Copy link
Contributor Author

@grantfirl @haiqinli Grant, I haven't run RT because this one-line change fixes the diagnostic variable and does not change the model performance. I asked @haiqinli to merge it into his next PR.

@grantfirl
Copy link
Collaborator

@jkbk2004 This PR can be closed because it has been brought into #2147. Although it is directed at the RRFS release branch, these changes will make their way to develop after the release.

@jkbk2004
Copy link
Collaborator

This pr is followed up with #2147.

@jkbk2004 jkbk2004 closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants