Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Update UFS-WM, UFS_UTILS, and UPP hashes. #892

Closed

Conversation

MichaelLueken
Copy link
Collaborator

DESCRIPTION OF CHANGES:

  • The UFS-WM hash has been updated to bb525bb (August 16, 2023), the UPP hash has been updated to baa7751 (July 17, 2023), and the UFS_UTILS hash has been updated to a8dd34d (August 16, 2023).
  • The GST_release_public_v1 test has been removed from the WE2E tests.
  • A new NOAH MP land file, noahmptable.tbl, has been added (required to run the forecast following a2088bf).

Type of change

  • New feature (non-breaking change which adds functionality)
  • New features from hash updates
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Removal of GST_release_public_v1 test

TESTS CONDUCTED:

  • hera.intel
  • hera.gnu
  • orion.intel
  • gaea.intel
  • jet.intel
  • fundamental test suite
  • comprehensive tests were run on hera.intel. It should be noted that the nco_grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR test failed in the comprehensive test suite. However, the Jet coverage tests successfully pass, which includes this test, as well as running the test by itself on Hera. Failure could be due to issue NCO mode (run_envir="nco") results in random failures for WE2E tests #652.

ISSUE:

Fixes #874

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

@MichaelLueken
Copy link
Collaborator Author

As @mkavulich noted in today's SRW CM meeting, rather than put a random table in a third repository, I will change this to a draft PR until GitHub Discussion #1877 has been addressed and a clear path forward has been decided.

@MichaelLueken
Copy link
Collaborator Author

PR #906 supersedes this PR. Closing this PR now.

@MichaelLueken MichaelLueken deleted the feature/update-hashes branch September 14, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

GST_release_public_v1 test fails on Hera in latest develop
1 participant