Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial CI #13

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Initial CI #13

wants to merge 15 commits into from

Conversation

zmoon
Copy link
Collaborator

@zmoon zmoon commented Sep 5, 2023 •
edited
Loading

  • pre-commit (findent and white space)
  • document pre-commit setup
  • CMake config for the schemes and data/params/config (not driver routines so far)
  • document how to build
  • address strict GFortran build errors
  • address some of the warnings, maybe adjust some warnings to be errors
  • run pre-commit and build in GHA CI
  • incorporate changes from Update FENGSHA and dust schemes #10 and Update to Seasalt: Code Cleanup and bin invariance  #11 after they are merged
  • add at least one (unit) test (to be sure the setup is working)
  • document how to run the tests
  • put workflow push branch guards back

Resolves #12

@zmoon zmoon marked this pull request as ready for review September 5, 2023 22:22
@zmoon zmoon marked this pull request as draft September 5, 2023 22:24
@zmoon
Copy link
Collaborator Author

zmoon commented Sep 6, 2023

Although the CI is not currently running here, I can see it ran in my fork after I disabled the repo and push branch guards.

zmoon pushed a commit to zmoon/CATChem that referenced this pull request Jun 3, 2024
@bbakernoaa
Merge pull request ufs-community#13 from bbakernoaa/remove_geoschem_d…
bb6146c 
…ocstrings

Removing GeosChem Docstring - first attempt at doxygen docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial CI
1 participant
@zmoon