-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue-3): Transition with editor destruction #5772
Conversation
🦋 Changeset detectedLatest commit: 637dc54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, appreciate your contribution!
Changes Overview
I changed the
useEditor
composable so that it supports transitions if the editor is in the same component as the Transition, and now also if the editor itself is a descendant.Implementation Approach
I made a DOM clone of the content before the destroy in the useEditor composable. Then Vue removes the nodes when transition is over.
Testing Done
Verification Steps
Going to the examples section and to Transition. In the
index.vue
component, both examples are shown. One example where the editor is hosted in the same component as the transition, and one where it's nested.Checklist
Related Issues
#5752 and #5646
See also #5648