Fix/blockquote commands #5746
Open
Fix/blockquote commands #5746
+150
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the cursor is in a `listItem`, setting or unsetting `blockquote` is allowed.
…is on the first paragraph of a `listItem`, setting `blockquote` should be allowed, and the `blockquote` will wrap the entire list.
…en the cursor is on the first element of a list item, setting `blockquote` will wrap the entire list; and when the cursor is on the second element of a list item, setting `blockquote` will only wrap the second element.
…or.lift` leads to incorrect modifications.
|
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Fix the issues with
setBlockquoteandunsetBlockquotecommands.Implementation Approach
Tiptap checks
isNodeActiveby searching upwards from the current position, and based on the result, it executes eitherwrapInorlift. However, ProseMirror'swrapInandliftonly evaluate the currentblockRange, which can cause the command to not function as expected.To address this, add a
findWrappingUntilhelper, which will search upwards until it finds a valid wrapping position. This will resolve issue #3743.Additionally, add a
nodeTypecheck when retrievingblockRangein theliftcommand, which will resolve issue #4434.Testing Done
In the example default editor, a
disabledattribute was added to the blockquote action button. This will disable the button when the action cannot be performed. Theidattribute was also added for better Cypress testing.Three test cases were added:
toggleBlockquotewill wrap the entire list.toggleBlockquotewill wrap only the second element.toggleBlockquotewill remove the blockquote wrapping without altering the list.Verification Steps
Visit the default editor page or run the Cypress tests.
Additional Notes
It seems we should directly modify
commands.wrapIninstead of changingsetBlockquotein the blockquote extension. The range of checks inProseMirror.wrapInandtiptap.isNodeActiveare inconsistent, which may be the core issue.On the other hand, the situation with
commands.liftis the opposite, aslifthas a specific node type. We must search upwards from the current position to find the required type.Checklist
Related Issues