Fix off by one error for images (and probably other atomic nodes) #5327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Fixes NodePos miscalculation for images
Implementation Approach
Reverts the spirit, but not letter, of the approach that was used before the regression occurred: https://github.com/ueberdosis/tiptap/pull/5038/files#diff-deab15d8918868fc71b9ad8ee3afa808f6b4be07c48e915fd0aed512493fd90cL139
Testing Done
TESTING WAS NOT DONE
Verification Steps
Additional Notes
@masylum your help confirming this PR works as intended would be greatly appreciated
Checklist
Related Issues
#5314