Create Core Plugin QueryCacheToSate #3221
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
felixfeng33
requested review from
12joan and
zbeyens
and removed request for
12joan
|
|
||
| const { apply } = editor; | ||
|
|
||
| editor.apply = (operation) => { |
There was a problem hiding this comment.
I think editor.onChange is a better fit
There was a problem hiding this comment.
I've left some comments pertaining to this on Discord. https://discord.com/channels/1026227597115396188/1237021058067075072
| }; | ||
| }; | ||
|
|
||
| export const withQueryCachToState = < |
There was a problem hiding this comment.
Let's name the plugin cache instead of queryCacheToState
|
|
||
| export type QueryCachToSateEditor<V extends Value> = { | ||
| state: { | ||
| aboveEntries?: Generator<TNodeEntry<ENode<V>>, void, undefined>; |
There was a problem hiding this comment.
let's reuse the same naming convention than Slate queries. For example Transforms.above -> above. For Plate exclusive, just try to follow the same pattern
| import { createPluginFactory } from '../utils/createPluginFactory'; | ||
|
|
||
| export type QueryCachToSateEditor<V extends Value> = { | ||
| state: { |
There was a problem hiding this comment.
cache may be better. What do you think @12joan ?
| @@ -19,5 +19,9 @@ export function PlateEffects< | |||
| >({ children, ...props }: PlateEffectsProps<V, E>) { | |||
| usePlateEffects<V, E>(props); | |||
|
|
|||
| return <>{children}</>; | |||
| return ( | |||
| <div data-id={props.id} id="plate-editor"> | |||
There was a problem hiding this comment.
toc Plugin need the container dom node to scroll to heading.I haven't thought of a good method to obtain container nodes.
There was a problem hiding this comment.
You can get Slate's root contenteditable by passing the editor to toDOMNode.
| export const KEY_QUERY_CACHE_TO_STATE = 'queryCacheToSate'; | ||
|
|
||
| export const createQueryCachToStatePlugin = createPluginFactory({ | ||
| key: KEY_QUERY_CACHE_TO_STATE, |
There was a problem hiding this comment.
let's add a boolean option for each query: don't run if false
There was a problem hiding this comment.
I've left some comments pertaining to this on Discord. https://discord.com/channels/1026227597115396188/1237021058067075072
Description
QueryCacheToSate:
editor.applyis appropriate.PlateEffects:
I will fix the test cases and add a changeset just before merging.