Fix For Issue #250 #251
Merged
Fix For Issue #250 #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd test to demonstrate difference.
|
Can you add the test to the CI? I know it's silly but we may as well have it in there. I'll take a look at why the mac CI is failing, but it's nothing this PR has changed. |
|
Added the test case to the CI. It should not crash and also it should not type check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have a function call and you try to take the head of the arguments list you may crash if the argument list is empty. The issue #250 boils down to just that. Instead of taking the head of the argument list, we wrap the correct type in a list and compare that with the argument list.
I am also adding an example that crashed before the change but correctly reports an error after the change. It is kind of silly so I am not adding it to the CI.