Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/vmap optstate #167

Merged
merged 20 commits into from
Oct 27, 2023
Merged

F/vmap optstate #167

merged 20 commits into from
Oct 27, 2023

Conversation

Aidandos
Copy link
Collaborator

All Submissions:

IMPORTANT: if this Pull Request concerns an existing issue, please provide the GitHub issue number, otherwise please create an issue first.

Associated issue: #XXXX

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

Copy link
Collaborator

@chrismatix chrismatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a lot of runners that I am not familiar with so only checked code that I was familiar with.

@@ -362,6 +362,12 @@ def _rollout(
a2_rng,
agent2._mem.hidden,
)
# generate an array of shape [10]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Commented out code.

@Aidandos Aidandos merged commit 430b254 into main Oct 27, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants