Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write_db is not required for non physical aware flow #864

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

vikramjain236
Copy link
Contributor

The command "write_db -common" is only necessary when doing physical aware flow. But even with the phys_flow_effort set to none, the command is written by default which breaks the genus synthesis flow. Added a condition to not use the command for non physical aware flow.
Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

@harrisonliew harrisonliew added this pull request to the merge queue Jun 11, 2024
Merged via the queue into master with commit 5475322 Jun 11, 2024
4 checks passed
@harrisonliew harrisonliew deleted the fix_phys_flow branch June 11, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants