Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReadTheDocs Builds With Poetry 1.8 #846

Closed
wants to merge 1 commit into from

Conversation

vighneshiyer
Copy link
Contributor

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

Poetry 1.8 introduced a stricter virtualenv detection mechanism which doesn't recognize the RTD python virtualenv when running poetry install. To fix this, we manually specify the VIRTUAL_ENV when running poetry install in the RTD script. (see: readthedocs/readthedocs.org#11152)

@harrisonliew
Copy link
Contributor

Superceded by #847

@harrisonliew harrisonliew deleted the rtd_poetry1v8_fix branch March 7, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants