Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple rounds of opt_design in Innovus plugin #837

Closed
wants to merge 2 commits into from

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Dec 15, 2023

Most designs should only run 1 round.
This is very occasionally useful, and should be used judiciously

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of this, for a few reasons:

  • There appears to be an -incremental flag, although this disables hold & power opts
  • Even more targeted: a -targeted flag to only change specific paths
  • We should probably change the opt category attributes to tune this behavior. User guide also suggests this between iterations of opt.
  • If hold is a concern, we can do an opt_design -post_cts -hold at the end of CTS
  • We should also be using opt_signoff after opt_design anyway

@jerryz123 jerryz123 closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants