Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowgraph constructions #773

Merged
merged 39 commits into from
Feb 8, 2024
Merged

Flowgraph constructions #773

merged 39 commits into from
Feb 8, 2024

Conversation

bdngo
Copy link
Contributor

@bdngo bdngo commented Mar 23, 2023

This PR implements a functioning prototype for flowgraphs, a more idiomatic way of representing VLSI flows. With this, instead of stringing multiple CLI calls to hammer-vlsi, one can construct a Graph consisting of Nodes encoding Hammer actions. The feature makes heavy use of the networking package NetworkX to manipulate flowgraphs. Flowgraphs are nothing more than Python dataclass instantiations, making them modular and reusable. Ideally, flowgraphs and the current workflow for Hammer will coexist for now, with pending ports of advanced Hammer features.

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

hammer/flowgraph/node.py Outdated Show resolved Hide resolved
hammer/flowgraph/node.py Outdated Show resolved Hide resolved
hammer/flowgraph/node.py Outdated Show resolved Hide resolved
@bdngo bdngo marked this pull request as ready for review May 11, 2023 18:06
Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to wait til after the current tapeout to merge this. So, if you have the time, I'd like to see the e2e Makefile duplicated in the form of a flowgraph. Else, it can come as a future PR.

hammer/flowgraph/flowgraph.py Show resolved Hide resolved
doc/Hammer-Use/index.rst Outdated Show resolved Hide resolved
@harrisonliew harrisonliew added this pull request to the merge queue Feb 8, 2024
Merged via the queue into master with commit 9cca4eb Feb 8, 2024
3 checks passed
@harrisonliew harrisonliew deleted the flowgraph branch February 8, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants