Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kinoite): Include missing KDE image format codecs #660

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

NiHaiden
Copy link
Contributor

This includes the missing JPEG-XL and other codec support which is present in F40 Kinoite Builds but not in the F41 builds. Downstream Issue Example: ublue-os/bluefin#1811

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 30, 2024
@@ -133,7 +133,10 @@
"41": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed in 40 now, since it will be included in all kinoite versions:

    "40": {
        "include": {
            "all": [],
            "kinoite": []

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But wouldn't that break the support on current Fedora 40 based images?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a mistake in looking, sorry

Copy link
Contributor

@fiftydinar fiftydinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 30, 2024
@bsherman
Copy link
Contributor

This includes the missing JPEG-XL and other codec support which is present in F40 Kinoite Builds but not in the F41 builds. Downstream Issue Example: ublue-os/bluefin#1811

For additions to main, I am pretty uptight about always calling out how this fits in our project/image scope.

In this case, I do think @NiHaiden provided the information in the description.

This isn't a net-add, rather it's maintaining expected behavior from F40 in F41 builds.

I'm good with this.

👍

@KyleGospo KyleGospo added this pull request to the merge queue Oct 30, 2024
Merged via the queue into ublue-os:main with commit 147b76b Oct 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants