-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kinoite): Include missing KDE image format codecs #660
Conversation
@@ -133,7 +133,10 @@ | |||
"41": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed in 40
now, since it will be included in all kinoite versions:
"40": {
"include": {
"all": [],
"kinoite": []
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But wouldn't that break the support on current Fedora 40 based images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a mistake in looking, sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go
For additions to main, I am pretty uptight about always calling out how this fits in our project/image scope. In this case, I do think @NiHaiden provided the information in the description. This isn't a net-add, rather it's maintaining expected behavior from F40 in F41 builds. I'm good with this. 👍 |
This includes the missing JPEG-XL and other codec support which is present in F40 Kinoite Builds but not in the F41 builds. Downstream Issue Example: ublue-os/bluefin#1811