fix: nvidia fixes #292
Merged
fix: nvidia fixes #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsherman
requested review from
castrojo,
HikariKnight,
noelmiller,
KyleGospo,
p5 and
m2Giles
HikariKnight
previously approved these changes
Oct 28, 2024
castrojo
previously approved these changes
Oct 28, 2024
KyleGospo
previously approved these changes
Oct 28, 2024
This fixes power management on optimus laptops, specifically for Ampere+ where the specified config was preventing D3cold state. Upstream negativo17 should be notified of this change, too. Fix: #290
bsherman
changed the title
HikariKnight
approved these changes
Oct 28, 2024
KyleGospo
approved these changes
Oct 28, 2024
castrojo
approved these changes
Oct 28, 2024
|
Force merge because merge checks are happening while F41 is in flux. |
This was referenced Oct 29, 2024
|
Last night I apparently clicked the wrong button when attempting to force merge. Ugh. Reopening to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: chromium browser use of hw accel on hybrid laptops
This has been tested via live-stream with multiple ublue-os team members.
We concur that this will retain the fix of pre-loaded nvidia which enables plymouth boot screen to show rather than only a blank screen.
This will, however, pre-load i915 & amdgpu drivers on all nvidia machines, even desktops which only have discrete nvidia cards. It's a fair compromise for us suckers who run nvidia, to have an image which works for all. A loaded kmod which doesn't have any actual hardware though, does not cause harm, just a bit of extra memory used.
The group deemed it a fair trade off for now.
Fixes: #285
fix: use default nvidia driver power management
This fixes power management on optimus laptops, specifically for Ampere+
where the specified config was preventing D3cold state.
Upstream negativo17 should be notified of this change, too.
Fixes: #290