Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macros UBLK_CONTROL and UBLKC_PREFIX #75

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

mattysweeps
Copy link
Contributor

@mattysweeps mattysweeps commented Oct 17, 2024

Some users might mount devtmpfs to a location other than /dev.
This means the /dev/ublk-control device might exist at a different
location on the filesystem.

Similarly /dev/ublkc[0-9] devices might exist in different places.

The macros UBLK_CONTROL and UBLKC_PREFIX configure the locations of
these devices. UBLK_CONTROL is the full name of the control device,
and UBLKC_PREFIX is the parent directory of all ublkc[0-9] devices.

Fixes #74

@mattysweeps mattysweeps changed the title Parameterize /dev/ublk-control Add macro DEVTMPFS Oct 18, 2024
@ming1
Copy link
Collaborator

ming1 commented Oct 19, 2024

Hello,

I feel it is still not flexible by just adding macro of DEVTMPFS, what do you thinking of adding macros of UBLK_CONTROL and UBLKC_PREFIX?

Maybe someone add udev rule to change ublkc to other name?

Thanks,

Some users might mount devtmpfs to a location other than /dev.
This means the /dev/ublk-control device might exist at a different
location on the filesystem.

Similarly /dev/ublkc[0-9] devices might exist in different places.

The macros UBLK_CONTROL and UBLKC_PREFIX configure the locations of
these devices. UBLK_CONTROL is the full name of the control device,
and UBLKC_PREFIX is the parent directory of all ublkc[0-9] devices.
@mattysweeps
Copy link
Contributor Author

Hello,

I feel it is still not flexible by just adding macro of DEVTMPFS, what do you thinking of adding macros of UBLK_CONTROL and UBLKC_PREFIX?

Maybe someone add udev rule to change ublkc to other name?

Thanks,

Thanks @ming1,

Sure thing. I updated the commit to have UBLK_CONTROL and UBLKC_PREFIX respectively.
Also please let me know what style you prefer for the configure flag. (--with-ublk_control or --with-ublk-control)

@mattysweeps mattysweeps changed the title Add macro DEVTMPFS Add macros UBLK_CONTROL and UBLKC_PREFIX Oct 21, 2024
@ming1
Copy link
Collaborator

ming1 commented Oct 22, 2024

Hello,
I feel it is still not flexible by just adding macro of DEVTMPFS, what do you thinking of adding macros of UBLK_CONTROL and UBLKC_PREFIX?
Maybe someone add udev rule to change ublkc to other name?
Thanks,

Thanks @ming1,

Sure thing. I updated the commit to have UBLK_CONTROL and UBLKC_PREFIX respectively. Also please let me know what style you prefer for the configure flag. (--with-ublk_control or --with-ublk-control)

I am fine with either one, but maybe '--with-ublk-control' can save one key, :-)

@ming1 ming1 merged commit fa4439c into ublk-org:master Oct 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameterize /dev/ublk-control
2 participants