Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update erb-formatter version
We were using a forked version of nebula/erb-formatter due to these two
commits:
These issues have been fixed upstream, so I initially planned to switch
to the official package. However, I encountered another problem and
created two PRs to address them. Unfortunately, I didn't receive any
response from the maintainer. Thus, I've decided to continue using our
updated forked version.
Fix icon.erb ignoring for erb-formatter
We have a large 'when' block in the icon.erb file, and erb-formatter
makes it difficult to read. Although I tried to exclude the icon.erb
file, it appears to be wrong. At the moment, all files starting with the
letters 'i', 'c', 'o', 'n' are ignored, resulting in multiple files not
being formatted by the erb-formatter.
Increase erb-formatter line-width from 120 to 160
We format HTML/ERB files using the erb-formatter and Tailwind CSS,
resulting in many long lines in our view files. After trying various
line-widths, 160 appears to be the most suitable for our needs to me.
Fix unclosed
tag at otp_setup.erb
Both
<br>
and</br>
are valid HTML tags. But erb-formatter couldn'tformat
</br>
and raises the following exception.Format with new version of erb-formatter