Set package_type in android_binary rules

uber · Dec 13, 2017 · 9994d90 · 9994d90
1 parent 9412088
commit 9994d90
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/.buckconfig b/.buckconfig
@@ -36,3 +36,7 @@
 
 [ui]
     build_rule_minimum_duration_millis = 500
+
+[ndk]
+    gcc_version=4.9
+    app_platform = android-24
diff --git a/buildSrc/src/main/groovy/com/uber/okbuck/composer/android/AndroidBinaryRuleComposer.groovy b/buildSrc/src/main/groovy/com/uber/okbuck/composer/android/AndroidBinaryRuleComposer.groovy
@@ -51,6 +51,7 @@ final class AndroidBinaryRuleComposer extends AndroidBuckRuleComposer {
                 .cpuFilters(mappedCpuFilters)
                 .minifyEnabled(target.minifyEnabled)
                 .proguardConfig(fileRule(proguardConfig))
+                .debuggable(target.debuggable)
                 .placeholders(target.placeholders)
                 .includesVectorDrawables(target.includesVectorDrawables)
                 .preprocessJavaClassesDeps(transformDeps)

diff --git a/buildSrc/src/main/rocker/com/uber/okbuck/template/android/AndroidBinaryRule.rocker.raw b/buildSrc/src/main/rocker/com/uber/okbuck/template/android/AndroidBinaryRule.rocker.raw
@@ -5,6 +5,7 @@ String manifestSkeleton,
 String keystore,
 String preprocessJavaClassesBash,
 String proguardConfig,
+boolean debuggable,
 int linearAllocHardLimit,
 Collection primaryDexPatterns,
 Collection cpuFilters,
@@ -55,6 +56,11 @@ boolean multidexEnabled,
     android_sdk_proguard_config = 'none',
     proguard_config = '@proguardConfig',
 }
+@if (debuggable) {
+    package_type = 'debug',
+} else {
+    package_type = 'release',
+}
 @if (includesVectorDrawables) {
     includes_vector_drawables = True,
 }