Add ActivityTracker to worker stats option #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketsiambaku
requested review from
Groxx,
shijiesheng,
jakobht,
3vilhamster,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Continue to review full report in Codecov by Sentry.
|
ketsiambaku
changed the title
ketsiambaku
force-pushed
the
activity-stats
branch
from
ec86220
to
cc6c739
Compare
ketsiambaku
force-pushed
the
activity-stats
branch
from
cc6c739
to
d7346b6
Compare
ketsiambaku
commented
Aug 29, 2024
| return &activityStopperImpl{info: info, tracker: ati} | ||
| } | ||
|
|
||
| func (ati *activityTrackerImpl) Stats() Activities { |
There was a problem hiding this comment.
We can group Activities by activityType or other fields of ActivityInfo if needed internally
3vilhamster
reviewed
Aug 29, 2024
jakobht
approved these changes
Aug 29, 2024
3vilhamster
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This changes adds the ActivityTracker in the worker options. In this PR, to count and get information on running activities in a worker.
The activityTracker field is added to activityTaskHandler and localActivityTaskHandler and emitted upon calling Execute() ExecuteWithActualArgs() for local activity.
Why?
Want to retrieve running activities on a worker instance
How did you test it?
unit tests
local test
Potential risks
When deploying the noop implementation is used by default
potential risks include nil pointer dereference panics in the event that we missed initializing the activityTracker in a particular flow