run linter and add type comments

uber-go · Aug 29, 2024 · f4fe6f9 · f4fe6f9
1 parent 3d2e3e3
commit f4fe6f9
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 9 deletions.
diff --git a/debug/types.go b/debug/types.go
@@ -48,7 +48,7 @@ type (
 	// Deprecated: in development and very likely to change
 	ActivityInfo = internal.ActivityInfo
 
-	// Activities ...
+	// Activities is a list of executing activities on the worker
 	// Deprecated: in development and very likely to change
 	Activities = internal.Activities
 )
diff --git a/internal/common/debug/example_test.go b/internal/common/debug/example_test.go
@@ -23,8 +23,9 @@ package debug
 import (
 	"encoding/json"
 	"fmt"
-	"go.uber.org/atomic"
 	"sync"
+
+	"go.uber.org/atomic"
 )
 
 type (

diff --git a/internal/common/debug/types.go b/internal/common/debug/types.go
@@ -47,7 +47,7 @@ type (
 		ActivityTracker ActivityTracker
 	}
 
-	// ActivityInfo ...
+	// ActivityInfo contains details on the executing activity
 	// Deprecated: in development and very likely to change
 	ActivityInfo struct {
 		WorkflowID   string
@@ -59,13 +59,14 @@ type (
 	// ActivityTracker is a worker option to track executing activities on a worker
 	// Deprecated: in development and very likely to change
 	ActivityTracker interface {
-		// Start ...
+		// Start records activity execution
 		Start(info ActivityInfo) Stopper
-		// Stats ...
+		// Stats returns a list of executing activity info
 		Stats() Activities
 	}
 
-	// Activities ...
+	// Activities is a list of executing activities on the worker
+	// Deprecated: in development and very likely to change
 	Activities []struct {
 		Info  ActivityInfo
 		Count int64

diff --git a/internal/internal_task_handlers.go b/internal/internal_task_handlers.go
@@ -27,14 +27,15 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"go.uber.org/cadence/internal/common/debug"
 	"math"
 	"reflect"
 	"strings"
 	"sync"
 	"sync/atomic"
 	"time"
 
+	"go.uber.org/cadence/internal/common/debug"
+
 	"github.com/opentracing/opentracing-go"
 	"github.com/uber-go/tally"
 	"go.uber.org/zap"

diff --git a/internal/internal_task_pollers.go b/internal/internal_task_pollers.go
@@ -27,10 +27,11 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"go.uber.org/cadence/internal/common/debug"
 	"sync"
 	"time"
 
+	"go.uber.org/cadence/internal/common/debug"
+
 	"github.com/opentracing/opentracing-go"
 	"github.com/pborman/uuid"
 	"github.com/uber-go/tally"

diff --git a/internal/internal_workflow_testsuite.go b/internal/internal_workflow_testsuite.go
@@ -25,12 +25,13 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"go.uber.org/cadence/internal/common/debug"
 	"reflect"
 	"strings"
 	"sync"
 	"time"
 
+	"go.uber.org/cadence/internal/common/debug"
+
 	"github.com/facebookgo/clock"
 	"github.com/golang/mock/gomock"
 	"github.com/opentracing/opentracing-go"