Fix replay for child workflow and release restriction for in-complete… (

#755)

idl/github.com/uber/cadence/shared.thrift

@@ -464,8 +464,9 @@ struct WorkflowExecutionStartedEventAttributes {
   56: optional string continuedFailureReason
   57: optional binary continuedFailureDetails
   58: optional binary lastCompletionResult
-  59: optional string originalExecutionRunId // This is the very first runID along the chain of ContinueAsNew and Reset.
+  59: optional string originalExecutionRunId // This is the runID when the WorkflowExecutionStarted event is written
   60: optional string identity
+  61: optional string firstExecutionRunId // This is the very first runID along the chain of ContinueAsNew and Reset.
   70: optional RetryPolicy retryPolicy
   80: optional i32 attempt
   90: optional i64 (js.type = "Long") expirationTimestamp

internal/worker.go

@@ -328,9 +328,6 @@ func replayWorkflowHistory(logger *zap.Logger, service workflowserviceclient.Int
 		return errors.New("first event is not WorkflowExecutionStarted")
 	}
 	last := events[len(events)-1]
-	if last.GetEventType() != shared.EventTypeWorkflowExecutionCompleted && last.GetEventType() != shared.EventTypeWorkflowExecutionContinuedAsNew {
-		return errors.New("last event is not WorkflowExecutionCompleted or WorkflowExecutionContinuedAsNew")
-	}
 
 	attr := first.WorkflowExecutionStartedEventAttributes
 	if attr == nil {
@@ -341,6 +338,10 @@ func replayWorkflowHistory(logger *zap.Logger, service workflowserviceclient.Int
 		RunId:      common.StringPtr(uuid.NewUUID().String()),
 		WorkflowId: common.StringPtr("ReplayId"),
 	}
+	if first.WorkflowExecutionStartedEventAttributes.GetOriginalExecutionRunId() != "" {
+		execution.RunId = common.StringPtr(first.WorkflowExecutionStartedEventAttributes.GetOriginalExecutionRunId())
+	}
+
 	task := &shared.PollForDecisionTaskResponse{
 		Attempt:                common.Int64Ptr(0),
 		TaskToken:              []byte("ReplayTaskToken"),
@@ -372,6 +373,10 @@ func replayWorkflowHistory(logger *zap.Logger, service workflowserviceclient.Int
 	if err != nil {
 		return err
 	}
+
+	if last.GetEventType() != shared.EventTypeWorkflowExecutionCompleted && last.GetEventType() != shared.EventTypeWorkflowExecutionContinuedAsNew {
+		return nil
+	}
 	err = fmt.Errorf("replay workflow doesn't return the same result as the last event, resp: %v, last: %v", resp, last)
 	if resp != nil {
 		completeReq, ok := resp.(*shared.RespondDecisionTaskCompletedRequest)