Skip to content

Commit

Permalink
Use -filelist when linking swift_library as the list of objects can b…
Browse files Browse the repository at this point in the history
…e too long
  • Loading branch information
Alessandro Patti committed Nov 4, 2019
1 parent 9282bc5 commit b1cb117
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions swift/internal/linking.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ def _register_static_library_link_action(
)
args = actions.args()
args.add_all(command_line)
args.add_all(objects)
args.add("-filelist")
objects_args = actions.args()
objects_args.set_param_file_format("multiline")
objects_args.use_param_file("%s", use_always=True)
objects_args.add_all(objects)

env = cc_common.get_environment_variables(
action_name = CPP_LINK_STATIC_LIBRARY_ACTION_NAME,
Expand All @@ -68,7 +72,7 @@ def _register_static_library_link_action(

actions.run(
executable = archiver_path,
arguments = [args],
arguments = [args, objects_args],
env = env,
# TODO(allevato): It seems like the `cc_common` APIs should have a way to get this value
# so that it can be handled consistently for the toolchain in use.
Expand Down

0 comments on commit b1cb117

Please sign in to comment.