up chunk sizes #62
Merged
up chunk sizes #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gillins Yes, I think this is was I understood from the presentation. Will be interesting to see what difference it makes. |
|
@petebunting just to close the loop on this. Turns out setting paged aggregation really increases the file size:
So I think it's worth changing the chunksize (all that this PR now does) but let's not bother with the paged aggregation. It increases the filesize by quite a lot (probably because we have lots of small datasets in a KEA file - ie each block) plus breaks the API. With just changing the chunk size we do get smaller files. What do you think? |
|
Hi @gillins Yes, that sounds like a good way forward. I don't think we want file sizes growing that significantly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@petebunting is this what you understood from that presentation?
I haven't done any testing with it yet....
cc: @neilflood