Added station count in default header #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a helper function on the model of the self.parse_xxx() function in the code. The code use the info from data_sw and data_bw if available, to compute the number of total stations, and non-empty stations on the fly to be displayed.
Added **kwargs input to `_prepare_header()` to easily pass data (typically `data_bw` / `data_sw`) for the default header modification. It will likely be a good option to pass other fields to the header (like the grid).
rmodrak
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an attempt at the least invasive change for the header station count. It is based of the existing helper function structure in the
SourceHeaderclass with the addition ofparse_station_counts.It implements a way to count the total number of station, in case the body and surface waves were to be loaded from different weight file instances (in principle it should be rare, but that's an extra layer of precaution).
The next (and only) foreseeable change to the header would be the inclusion of an
*modifier added to fixed parameters. This should easily be done with the help of thegrid.shapeattributes, but we currently don't have a clean way of adding the grid (if we want to be the default behavior, we would have to change the input parameters forplot_data_greens1andplot_data_greens2).