mke2fs: uid and gid of the copied inodes when using -d option #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add MKE2FS_POPULATE_UID and MKE2FS_POPULATE_GID env vars for use with -d option - To implement mksquashfs -all-root option equivalent: the env vars will come in handy when creating a file system without root privileges
|
Just for reference, e2fsdroid has this piece of code dealing with uids/gids https://github.com/tytso/e2fsprogs/blob/master/contrib/android/perms.c#L134-L156 Not sure why they opted to do it in a post-processing step instead of fs_callback during population. In any case, it might make sense to align these two similar features? |
This was referenced Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added MKE2FS_POPULATE_UID and MKE2FS_POPULATE_GID env vars for use with -d option so that I don't have to use root privileges to change the uid and gid when the contents of source root directory are not owned by root.
mksquashfssets the uid and gid to 0 by default. I wanted this feature in mke2fs as well.I doubt the usefulness of these env vars as it seems no one really felt the need to implement these. I just wanted to put it out here so that someone can use my work.