Use abstract classes instead of traits for ADTs

typelevel · Apr 18, 2024 · 94cef84 · 94cef84
1 parent e2027e6
commit 94cef84
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/github-actions/src/main/scala/org/typelevel/sbt/gha/PREventType.scala b/github-actions/src/main/scala/org/typelevel/sbt/gha/PREventType.scala
@@ -16,7 +16,7 @@
 
 package org.typelevel.sbt.gha
 
-sealed trait PREventType extends Product with Serializable
+sealed abstract class PREventType extends Product with Serializable
 
 object PREventType {
   val Defaults = List(Opened, Reopened, Synchronize)

diff --git a/github-actions/src/main/scala/org/typelevel/sbt/gha/Paths.scala b/github-actions/src/main/scala/org/typelevel/sbt/gha/Paths.scala
@@ -16,7 +16,7 @@
 
 package org.typelevel.sbt.gha
 
-sealed trait Paths extends Product with Serializable
+sealed abstract class Paths extends Product with Serializable
 
 object Paths {
   final case class Include(paths: List[String]) extends Paths

diff --git a/github-actions/src/main/scala/org/typelevel/sbt/gha/Ref.scala b/github-actions/src/main/scala/org/typelevel/sbt/gha/Ref.scala
@@ -16,7 +16,7 @@
 
 package org.typelevel.sbt.gha
 
-sealed trait Ref extends Product with Serializable
+sealed abstract class Ref extends Product with Serializable
 
 object Ref {
   final case class Branch(name: String) extends Ref

diff --git a/github-actions/src/main/scala/org/typelevel/sbt/gha/RefPredicate.scala b/github-actions/src/main/scala/org/typelevel/sbt/gha/RefPredicate.scala
@@ -16,7 +16,7 @@
 
 package org.typelevel.sbt.gha
 
-sealed trait RefPredicate extends Product with Serializable
+sealed abstract class RefPredicate extends Product with Serializable
 
 object RefPredicate {
   final case class Equals(ref: Ref) extends RefPredicate

diff --git a/github-actions/src/main/scala/org/typelevel/sbt/gha/UseRef.scala b/github-actions/src/main/scala/org/typelevel/sbt/gha/UseRef.scala
@@ -16,7 +16,7 @@
 
 package org.typelevel.sbt.gha
 
-sealed trait UseRef extends Product with Serializable
+sealed abstract class UseRef extends Product with Serializable
 
 object UseRef {
   final case class Public(owner: String, repo: String, ref: String) extends UseRef

diff --git a/github-actions/src/main/scala/org/typelevel/sbt/gha/WorkflowStep.scala b/github-actions/src/main/scala/org/typelevel/sbt/gha/WorkflowStep.scala
@@ -16,7 +16,7 @@
 
 package org.typelevel.sbt.gha
 
-sealed trait WorkflowStep extends Product with Serializable {
+sealed abstract class WorkflowStep extends Product with Serializable {
   def id: Option[String]
   def name: Option[String]
   def cond: Option[String]

diff --git a/mergify/src/main/scala/org/typelevel/sbt/mergify/MergifyAction.scala b/mergify/src/main/scala/org/typelevel/sbt/mergify/MergifyAction.scala
@@ -142,7 +142,7 @@ object MergifyAction {
           )
       }
 
-    private sealed trait OptionallyWeighted
+    private sealed abstract class OptionallyWeighted
     private case class Weighted(value: NonEmptyList[(String, Int)]) extends OptionallyWeighted
     private case class Unweighted(value: NonEmptyList[String]) extends OptionallyWeighted