Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow set default convention endpoints behavior #9

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

picodotdev
Copy link
Contributor

@picodotdev picodotdev commented Mar 3, 2019

Summary of pull request changes:

  • Moved RouterDispatcher before PageRender dispatcher to allow configure behavior, ["after:ComponentEvent", "before:PageRender"].
  • Added Behavior enum.
  • Page without route and page route takes precedence over other route (same as current behavior).
  • Index pages can be used, routes can be used in Index pages, non Index pages routes takes precedence.
  • Added some test for RouterDispatcher and test route behavior.
  • Replaced deprecated request.getContextPath() usages with Symbol(SymbolConstants.CONTEXT_PATH).
  • Minor code style changes.

Fixes #8

@picodotdev
Copy link
Contributor Author

picodotdev commented Mar 3, 2019

Please review pull request changes and give a try, comments are welcome, I will try to add the necessary changes if any to be accepted if you find this useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant