Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ipywidgets 8 / Notebook 7 / JupyterLab 4 #93

Merged
merged 8 commits into from
Feb 1, 2024

Conversation

martinRenou
Copy link
Collaborator

@martinRenou martinRenou commented Sep 12, 2023

@martinRenou
Copy link
Collaborator Author

This does not work yet. There is some CodeMirror tweaking logic that does not work with JupyterLab 4 (CodeMirror 6).

This will require some days of work to get it right. Also we might want to consider dropping JupyterLab <=3 support, because supporting multiple CodeMirror versions may be tricky.

@martinRenou martinRenou force-pushed the update_ipywidgets8 branch 2 times, most recently from 7771863 to 95affc1 Compare September 26, 2023 12:33
@martinRenou martinRenou force-pushed the update_ipywidgets8 branch 4 times, most recently from 8bb63ba to 27b0de8 Compare September 26, 2023 14:02
@martinRenou
Copy link
Collaborator Author

Screenshot from 2024-01-03 10-25-25

This is now working nicely.

We need to update the beakerx_test repository in order for the e2e tests to pass.

@martinRenou martinRenou marked this pull request as ready for review January 3, 2024 15:07
@achhina
Copy link
Collaborator

achhina commented Jan 18, 2024

@martinRenou would this warrant a bump in version number?

@martinRenou
Copy link
Collaborator Author

Compatibility should be kept for JupyterLab 3.

As long as you built the wheel in an environment where JupyterLab 4 lives, the resulting wheel can be installed in an environment where JupyterLab 3 is installed.

So I guess a 2.4.0 bump is enough.

@martinRenou
Copy link
Collaborator Author

@achhina I think this is ready for merging. We can bump the version number separately.

@martinRenou martinRenou mentioned this pull request Feb 1, 2024
@TanayParikh TanayParikh merged commit 7d7cf4c into twosigma:master Feb 1, 2024
1 check failed
@martinRenou martinRenou deleted the update_ipywidgets8 branch February 1, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants