Added byteBuffer based APIs to support zerocopy calls for distributed… #4
Conversation
…log. Please review and merge these two changes together
|
sorry for late response. it looks good. |
| void update(byte[] data) { | ||
| update(data, 0, data.length); | ||
| } | ||
| /*void update(ByteBuffer data) { |
There was a problem hiding this comment.
can you just remove these lines rather than just commented out them?
|
@arvindkandhare some minor comments otherwise they look good to me |
sijie
force-pushed
the
master
branch
2 times, most recently
from
e430e6e
to
91c85ab
Compare
Utility for creating well-formed pull request merges and pushing them to Apache. A modified version based on Spark project (https://github.com/apache/spark/blob/master/dev/merge_spark_pr.py) Author: Sijie Guo <[email protected]> Reviewers: Matteo Merli <[email protected]> Closes twitter-archive#4 from sijie/sijie/BOOKKEEPER-885
|
@arvindkandhare are you porting this change to apache? if not, I can help you on this one. |
|
@sijie I have some time this week. I can get started on this. I will update this PR as well as create a new one for apache version. Will get back if I have any issues. |
|
thank you @arvindkandhare |
|
|
…log.
Please review and merge these two changes together