Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Handle Binary files correctly in Serverless Toolkit #508

Closed
wants to merge 2 commits into from

Conversation

dcanonmolina
Copy link

This is a fix to help the Serverless Toolkit to serve binary files. It could help to fix the issue: #421

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

 This is a fix to help the Serverless Toolkit to serve binary files. It could help to fix the issue: twilio-labs#421
Copy link

changeset-bot bot commented Feb 6, 2024

⚠️ No Changeset found

Latest commit: f57efed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@AndreLars AndreLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the needed checks to successfully run tests
On line 321
Property 'type' does not exist on type 'string'.
Property 'data' does not exist on type 'string'.

@makserik
Copy link
Contributor

@dcanonmolina are you still working on this?

@makserik
Copy link
Contributor

See the comment in #421

@makserik makserik closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants