Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade jest from 28.1.3 to 29.0.0 #491

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

twilio-product-security
Copy link
Contributor

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 661/1000
Why? Recently disclosed, Has a fix available, CVSS 7.5
Missing Release of Resource after Effective Lifetime
SNYK-JS-INFLIGHT-6095116
Yes No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: jest The new version differs by 76 commits.
  • 75006e4 v29.0.0
  • 7c82a9f chore: update jest-watch-typeahead again
  • 352ff29 chore: update changelog for release
  • 33ad8c3 docs: Jest 29 blog post (#13103)
  • dda77e5 docs: collapse 28.0 and 28.1 docs (#13104)
  • c0dc84c chore: update jest-watch-typeahead
  • 05f6217 fix: support deep CJS re-exports when using ESM (#13170)
  • 490fd88 chore: update yarn (#13169)
  • 98936a2 docs: Update Enzyme links to use new URL (#13166)
  • 187566a feat(pretty-format): allow to opt out from sorting object keys with `compareKeys: null` (#12443)
  • ae2bed7 chore: tweak regex used in e2e tests (#13129)
  • 8c56d74 docs: Update Configuration.md for added special notes on usage scenarios for pnpm. (#13115)
  • fb1c53d feat(jest-config)!: remove undocumented `collectCoverageOnlyFrom` option (#13156)
  • 075b489 fix: ignore `EISDIR` when resolving symlinks (#13157)
  • 3bef02e feat(@ jest/test-result, @ jest/types)!: replace `Bytes` and `Milliseconds` types with `number` (#13155)
  • 4def94b v29.0.0-alpha.6
  • 0f00d4e fix: replace non-CLI `rimraf` usage (#13151)
  • 6a90a2c fix: Allow updating inline snapshots when test includes JSX (#12760)
  • 983274a feat: Let `babel` find config when updating inline snapshots (#13150)
  • d2ff18a chore: make prettierPath optional in `SnapshotState` (#13149)
  • 7d8d01c feat(circus): added each to failing tests (#13142)
  • a5b52a5 chore(types): separate MatcherContext, MatcherUtils and MatcherState (#13141)
  • 79b5e41 chore: get rid of peer dep warning in website
  • 812763d chore: enable 'no-duplicate-imports' (#13138)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Copy link

changeset-bot bot commented Dec 3, 2023

⚠️ No Changeset found

Latest commit: d43f2c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@victoray victoray force-pushed the snyk-fix-3abeae9709e6c8bfb4782d00f368d8fd branch from 818cb0a to d9609b5 Compare March 15, 2024 13:26
@@ -25,6 +12,19 @@ jest.mock('@twilio-labs/serverless-api/dist/api/environments', () => {
};
});

const { init } = require('../src/init');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this moved, do we have to mock before importing now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-03-18 at 12 03 03 PM

automatic hoisting of mocks seems to be broken in v29, as it no longer works for es modules, I looked at the docs and found the above.

@victoray victoray merged commit 2c95fcf into main Mar 18, 2024
13 checks passed
@victoray victoray deleted the snyk-fix-3abeae9709e6c8bfb4782d00f368d8fd branch March 18, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants