Set cache metadata version to infinite TTL #8507
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the workspace cache storage service to prevent metadata version corruption by implementing an infinite TTL for metadata version cache entries.
- Added
TTL_INFINITE = 0constant in/packages/twenty-server/src/engine/workspace-cache-storage/workspace-cache-storage.service.ts - Modified
setMetadataVersion()to useTTL_INFINITEparameter for cache entries - Cache entries for metadata version will now persist indefinitely until manually cleared via
flush()
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
charlesBochet
approved these changes
Nov 14, 2024
charlesBochet
deleted the
c--set-cache-metadata-version-to-infinite-ttl
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
To avoid having a corrupt metadata version, we want to remove TTL for that key.
Test