Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search error in filter & sort dropdowns #8493

Merged

Conversation

harshrajeevsingh
Copy link
Contributor

Fixes: #8483

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes a DOM manipulation error in the dropdown search functionality by consolidating menu items into a single container structure.

  • Modified ObjectFilterDropdownFilterSelect.tsx to prevent 'removeChild' error by unifying dropdown menu items under one container
  • Updated ObjectSortDropdownButton.tsx to consolidate visible/hidden columns rendering within a single DropdownMenuItemsContainer
  • Simplified dropdown structure while maintaining filter/sort functionality and visible/hidden column separation
  • Added DropdownMenuSeparator inside the unified container instead of between separate containers

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@FelixMalfait FelixMalfait merged commit c966533 into twentyhq:main Nov 14, 2024
17 checks passed
Copy link

Thanks @harshrajeevsingh for your contribution!
This marks your 15th PR on the repo. You're top 2% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown Search Input Causing Error
2 participants