Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSV export missing last page #7167

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

charlesBochet
Copy link
Member

No description provided.

Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@charlesBochet charlesBochet merged commit 7781d70 into main Sep 20, 2024
5 of 9 checks passed
@charlesBochet charlesBochet deleted the csv-export-missing-last-page branch September 20, 2024 03:43
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses issues with CSV export functionality and improves GraphQL query filtering, focusing on data completeness and error prevention.

  • Modified useTableData.ts to ensure all records are exported in CSV, including the last page
  • Added a check in graphql-query-filter-field.parser.ts to prevent errors when using the 'in' operator with empty arrays or non-array values
  • Removed multiple test files related to GraphQL query parsing, potentially impacting test coverage
  • Improved robustness of query filtering mechanism in the back-end

5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants